From e0107a3d814583b3a521d254bbe09bfad1fc67ac Mon Sep 17 00:00:00 2001 From: Daniel Kempkens Date: Wed, 4 Oct 2023 11:04:29 +0200 Subject: [PATCH] chore: Use when clauses to aid the JIT in RenderUtils --- lib/bdfr_browser/render_utils.ex | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/bdfr_browser/render_utils.ex b/lib/bdfr_browser/render_utils.ex index 1530acd..08f8bb2 100644 --- a/lib/bdfr_browser/render_utils.ex +++ b/lib/bdfr_browser/render_utils.ex @@ -1,13 +1,13 @@ defmodule BdfrBrowser.RenderUtils do - def selftext(txt) do + def selftext(txt) when is_binary(txt) do Earmark.as_html!(txt) end - def comment(cmt) do + def comment(cmt) when is_binary(cmt) do Earmark.as_html!(cmt) end - def message(msg) do + def message(msg) when is_binary(msg) do img_replacement = "

" @@ -17,12 +17,12 @@ defmodule BdfrBrowser.RenderUtils do |> Earmark.as_html!() end - def link_to_user(name) when name in ~w([deleted] DELETED), do: name - def link_to_user(name), do: "#{name}" + def link_to_user(name) when is_binary(name) and name in ~w([deleted] DELETED), do: name + def link_to_user(name) when is_binary(name), do: "#{name}" # Helper - defp maybe_insert_image(<<"mxc://reddit.com/", filename::binary>> = msg, replacement) do + defp maybe_insert_image(<<"mxc://reddit.com/", filename::binary>> = msg, replacement) when is_binary(msg) do chat_directory = Application.fetch_env!(:bdfr_browser, :chat_directory) img_directory = Path.join([chat_directory, "images"]) imgs = Path.wildcard("#{img_directory}/#{filename}.*") @@ -35,5 +35,5 @@ defmodule BdfrBrowser.RenderUtils do end end - defp maybe_insert_image(msg, _replacement), do: msg + defp maybe_insert_image(msg, _replacement) when is_binary(msg), do: msg end